Refactor sycl offload #19464
Merged
Refactor sycl offload #19464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtoguchi
reviewed
Jul 22, 2025
Comment on lines
+1524
to
+1529
| auto &TC = getOffloadToolChain(C.getInputArgs(), Action::OFK_SYCL, TT, | ||
| HostTC->getTriple()); | ||
| C.addOffloadDeviceToolChain(&TC, Action::OFK_SYCL); | ||
|
|
||
| OffloadArchs[&TC] = getOffloadArchs(C, C.getArgs(), Action::OFK_SYCL, &TC, | ||
| /*SpecificToolchain=*/true); |
There was a problem hiding this comment.
nit - These can be moved into L1496
Comment on lines
+7514
to
+7520
| if (IsIntelGPUOffloadArch(Arch)) { | ||
| return Args.MakeArgStringRef(ArchStr); | ||
| } | ||
|
|
||
| if (IsIntelCPUOffloadArch(Arch)) { | ||
| return Args.MakeArgStringRef(ArchStr); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (IsIntelGPUOffloadArch(Arch)) { | |
| return Args.MakeArgStringRef(ArchStr); | |
| } | |
| if (IsIntelCPUOffloadArch(Arch)) { | |
| return Args.MakeArgStringRef(ArchStr); | |
| } | |
| if (IsIntelGPUOffloadArch(Arch) || | |
| IsIntelCPUOffloadArch(Arch)) { | |
| return Args.MakeArgStringRef(ArchStr); | |
| } |
mdtoguchi
reviewed
Jul 22, 2025
Update Toolchain creation behaviors when dealing with default toolchains Cleanup some formatting issues Fix sycl-unique-prefix.cpp Fix issue with -fhuge-link-device-code
mdtoguchi
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.